TST: Fail if parameterize set is empty #48924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
approved these changes
Oct 5, 2022
|
thx @mroeschke |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
lithomas1
added a commit
to lithomas1/pandas
that referenced
this pull request
Jan 31, 2023
5 tasks
mroeschke
added a commit
that referenced
this pull request
Mar 20, 2023
* BLD: Add pyproject.toml to wheels * Make strict-data-files opt out * Fixed backwards condition * Actually fix * Maybe fix all * Adjust options for other wheel builds * Error on unknown mark warning * Update pyproject.toml * Apply suggestions from code review Co-authored-by: Matthew Roeschke <[email protected]> * revert #48924 * update * fix syntax * fix warnings * Update test_nlargest.py * Update pyproject.toml --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.pytest.org/en/7.1.x/reference/reference.html#confval-empty_parameter_set_mark
I imagine if
pytest.mark.parameterizeis used, it is assumed that a test should be parameterized with more than 1 value, so this should prevent accidentally skipping a test if that isn't the case